Fix CSRF loading on static GET pages

main
Brian Picciano 2 years ago
parent 88ebaeda8f
commit 159638084e
  1. 3
      srv/src/http/api.go
  2. 19
      srv/src/http/csrf.go
  3. 5
      srv/src/http/tpl.go
  4. 2
      srv/src/http/tpl/assets.html
  5. 2
      srv/src/http/tpl/edit-post.html
  6. 13
      srv/src/http/tpl/load-csrf.html
  7. 3
      srv/src/http/tpl/posts.html

@ -163,6 +163,9 @@ func (a *api) Shutdown(ctx context.Context) error {
func (a *api) apiHandler() http.Handler { func (a *api) apiHandler() http.Handler {
mux := http.NewServeMux() mux := http.NewServeMux()
mux.Handle("/csrf", a.getCSRFTokenHandler())
mux.Handle("/pow/challenge", a.newPowChallengeHandler()) mux.Handle("/pow/challenge", a.newPowChallengeHandler())
mux.Handle("/pow/check", mux.Handle("/pow/check",
a.requirePowMiddleware( a.requirePowMiddleware(

@ -57,3 +57,22 @@ func checkCSRFMiddleware(h http.Handler) http.Handler {
h.ServeHTTP(rw, r) h.ServeHTTP(rw, r)
}) })
} }
func (a *api) getCSRFTokenHandler() http.Handler {
return http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {
csrfTok, err := apiutil.GetCookie(r, csrfTokenCookieName, "")
if err != nil {
apiutil.InternalServerError(rw, r, err)
return
}
apiutil.JSONResult(rw, r, struct {
CSRFToken string
}{
CSRFToken: csrfTok,
})
})
}

@ -100,6 +100,7 @@ func (a *api) mustParseTpl(name string) *template.Template {
func (a *api) mustParseBasedTpl(name string) *template.Template { func (a *api) mustParseBasedTpl(name string) *template.Template {
tpl := a.mustParseTpl(name) tpl := a.mustParseTpl(name)
tpl = template.Must(tpl.New("load-csrf.html").Parse(mustReadTplFile("load-csrf.html")))
tpl = template.Must(tpl.New("base.html").Parse(mustReadTplFile("base.html"))) tpl = template.Must(tpl.New("base.html").Parse(mustReadTplFile("base.html")))
return tpl return tpl
} }
@ -111,8 +112,8 @@ type tplData struct {
func (t tplData) CSRFFormInput() template.HTML { func (t tplData) CSRFFormInput() template.HTML {
return template.HTML(fmt.Sprintf( return template.HTML(fmt.Sprintf(
`<input type="hidden" name="%s" value="%s" />`, `<input type="hidden" name="%s" class="csrfHiddenInput" />`,
csrfTokenFormName, t.CSRFToken, csrfTokenFormName,
)) ))
} }

@ -46,6 +46,8 @@
</table> </table>
{{ template "load-csrf.html" . }}
{{ end }} {{ end }}
{{ template "base.html" . }} {{ template "base.html" . }}

@ -99,6 +99,8 @@
</form> </form>
{{ template "load-csrf.html" . }}
{{ end }} {{ end }}
{{ template "base.html" . }} {{ template "base.html" . }}

@ -0,0 +1,13 @@
<script async type="module" src="{{ StaticURL "api.js" }}"></script>
<script type="text/javascript">
(async () => {
const api = await import("{{ StaticURL "api.js" }}");
const res = await api.call("/api/csrf");
const els = document.getElementsByClassName("csrfHiddenInput");
for (let i = 0; i < els.length; i++) {
els[i].value = res.CSRFToken;
}
})();
</script>

@ -20,7 +20,6 @@
{{ $csrfFormInput := .CSRFFormInput }} {{ $csrfFormInput := .CSRFFormInput }}
<p style="text-align: center;"> <p style="text-align: center;">
<a href="{{ BlogURL "posts/" }}?edit"> <a href="{{ BlogURL "posts/" }}?edit">
<button>New Post</button> <button>New Post</button>
@ -56,6 +55,8 @@
{{ template "posts-nextprev" . }} {{ template "posts-nextprev" . }}
{{ template "load-csrf.html" . }}
{{ end }} {{ end }}
{{ template "base.html" . }} {{ template "base.html" . }}

Loading…
Cancel
Save