Re-arrange how api endpoints are defined

srv/src/api/api.go

@@ -152,57 +152,63 @@ func (a *api) handler() http.Handler {
 		staticHandler = httputil.NewSingleHostReverseProxy(a.params.StaticProxy)
 	}
 
-	staticHandler = setCSRFMiddleware(staticHandler)
-
 	// sugar
+
 	requirePow := func(h http.Handler) http.Handler {
 		return a.requirePowMiddleware(h)
 	}
 
+	postFormMiddleware := func(h http.Handler) http.Handler {
+		h = checkCSRFMiddleware(h)
+		h = postOnlyMiddleware(h)
+		h = logReqMiddleware(h)
+		h = addResponseHeaders(map[string]string{
+			"Cache-Control": "no-store, max-age=0",
+			"Pragma":        "no-cache",
+			"Expires":       "0",
+		}, h)
+		return h
+	}
+
 	mux := http.NewServeMux()
 
 	mux.Handle("/", staticHandler)
 
-	apiMux := http.NewServeMux()
+	{
-	apiMux.Handle("/pow/challenge", a.newPowChallengeHandler())
+		apiMux := http.NewServeMux()
-	apiMux.Handle("/pow/check",
+		apiMux.Handle("/pow/challenge", a.newPowChallengeHandler())
-		requirePow(
+		apiMux.Handle("/pow/check",
-			http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {}),
+			requirePow(
-		),
+				http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {}),
-	)
+			),
-
+		)
-	apiMux.Handle("/mailinglist/subscribe", requirePow(a.mailingListSubscribeHandler()))
+
-	apiMux.Handle("/mailinglist/finalize", a.mailingListFinalizeHandler())
+		apiMux.Handle("/mailinglist/subscribe", requirePow(a.mailingListSubscribeHandler()))
-	apiMux.Handle("/mailinglist/unsubscribe", a.mailingListUnsubscribeHandler())
+		apiMux.Handle("/mailinglist/finalize", a.mailingListFinalizeHandler())
-
+		apiMux.Handle("/mailinglist/unsubscribe", a.mailingListUnsubscribeHandler())
-	apiMux.Handle("/chat/global/", http.StripPrefix("/chat/global", newChatHandler(
+
-		a.params.GlobalRoom,
+		apiMux.Handle("/chat/global/", http.StripPrefix("/chat/global", newChatHandler(
-		a.params.UserIDCalculator,
+			a.params.GlobalRoom,
-		a.requirePowMiddleware,
+			a.params.UserIDCalculator,
-	)))
+			a.requirePowMiddleware,
-
+		)))
-	var apiHandler http.Handler = apiMux
+
-	apiHandler = checkCSRFMiddleware(apiHandler)
+		mux.Handle("/api/", http.StripPrefix("/api", postFormMiddleware(apiMux)))
-	apiHandler = postOnlyMiddleware(apiHandler)
+	}
-	apiHandler = logReqMiddleware(apiHandler)
+
-	apiHandler = addResponseHeaders(map[string]string{
+	{
-		"Cache-Control": "no-store, max-age=0",
+		v2Mux := http.NewServeMux()
-		"Pragma":        "no-cache",
+		v2Mux.Handle("/follow.html", a.renderDumbHandler("follow.html"))
-		"Expires":       "0",
+		v2Mux.Handle("/posts/", a.renderPostHandler())
-	}, apiHandler)
+		v2Mux.Handle("/assets", a.renderPostAssetsIndexHandler())
-
+		v2Mux.Handle("/assets/", a.servePostAssetHandler())
-	mux.Handle("/api/", http.StripPrefix("/api", apiHandler))
+		v2Mux.Handle("/", a.renderIndexHandler())
-
+
-	// TODO need to setCSRFMiddleware on all these rendering endpoints
+		mux.Handle("/v2/", http.StripPrefix("/v2", v2Mux))
-	mux.Handle("/v2/follow.html", a.renderDumbHandler("follow.html"))
+	}
-	mux.Handle("/v2/posts/", a.renderPostHandler())
-	mux.Handle("/v2/", a.renderIndexHandler())
-
-	mux.Handle("/v2/assets/", a.servePostAssetHandler())
-
-	mux.Handle("/v2/admin/assets.html", a.renderAdminAssets())
 
 	var globalHandler http.Handler = mux
+	globalHandler = setCSRFMiddleware(globalHandler)
 	globalHandler = setLoggerMiddleware(a.params.Logger, globalHandler)
 
 	return globalHandler

srv/src/api/render.go

@@ -197,9 +197,9 @@ func (a *api) renderDumbHandler(tplName string) http.Handler {
 	})
 }
 
-func (a *api) renderAdminAssets() http.Handler {
+func (a *api) renderPostAssetsIndexHandler() http.Handler {
 
-	tpl := a.mustParseTpl("admin/assets.html")
+	tpl := a.mustParseTpl("admin-assets.html")
 
 	return http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) {