mediocregopher/mediocre-go-lib
1
0
Fork 0
Code Releases Activity

m: don't log before populating params

Browse Source
This commit is contained in:
Brian Picciano 2019-02-24 17:25:53 -05:00
parent dd7bc43cf8
commit dc57aadb54
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
m/m.go
View File

@ -57,7 +57,9 @@ func ServiceContext() context.Context {
// Start performs the work of populating configuration parameters and triggering // Start performs the work of populating configuration parameters and triggering
// the start event. It will return once the Start event has completed running. // the start event. It will return once the Start event has completed running.
func Start(ctx context.Context) { func Start(ctx context.Context) {
mlog.Info("populating configuration", ctx) // no logging should happen before populate, primarily because log-level
// hasn't been populated yet, but also because it makes help output on cli
// look weird.
if err := mcfg.Populate(ctx, CfgSource()); err != nil { if err := mcfg.Populate(ctx, CfgSource()); err != nil {
mlog.Fatal("error populating configuration", ctx, merr.Context(err)) mlog.Fatal("error populating configuration", ctx, merr.Context(err))
} else if err := mrun.Start(ctx); err != nil { } else if err := mrun.Start(ctx); err != nil {