diff --git a/src/domain/acme/manager.rs b/src/domain/acme/manager.rs index 2a93bf9..78ae80e 100644 --- a/src/domain/acme/manager.rs +++ b/src/domain/acme/manager.rs @@ -1,8 +1,8 @@ -use std::{future, pin, sync, time}; +use std::{sync, time}; -use crate::domain::acme::{Certificate, PrivateKey}; -use crate::domain::{self, acme}; +use crate::domain::acme::{self, Certificate, PrivateKey}; use crate::error::unexpected::{self, Intoable, Mappable}; +use crate::{domain, util}; const LETS_ENCRYPT_URL: &str = "https://acme-v02.api.letsencrypt.org/directory"; @@ -14,7 +14,8 @@ pub trait Manager { fn sync_domain<'mgr>( &'mgr self, domain: domain::Name, - ) -> pin::Pin> + Send + 'mgr>>; + ) -> util::BoxedFuture<'mgr, Result<(), unexpected::Error>>; + fn get_http01_challenge_key(&self, token: &str) -> Result; /// Returned vec is guaranteed to have len > 0 @@ -86,8 +87,7 @@ impl Manager for ManagerImpl { fn sync_domain<'mgr>( &'mgr self, domain: domain::Name, - ) -> pin::Pin> + Send + 'mgr>> - { + ) -> util::BoxedFuture<'mgr, Result<(), unexpected::Error>> { Box::pin(async move { // if there's an existing cert, and its expiry (determined by the soonest value of // not_after amongst its parts) is later than 30 days from now, then we consider it to be diff --git a/src/domain/manager.rs b/src/domain/manager.rs index 13d5b71..96d666f 100644 --- a/src/domain/manager.rs +++ b/src/domain/manager.rs @@ -3,7 +3,7 @@ use crate::error::unexpected::{self, Mappable}; use crate::origin; use crate::util; -use std::{future, pin, sync}; +use std::sync; use tokio_util::sync::CancellationToken; #[derive(thiserror::Error, Debug)] @@ -146,13 +146,13 @@ pub trait Manager: Sync + Send + rustls::server::ResolvesServerCert { fn sync_cert<'mgr>( &'mgr self, domain: domain::Name, - ) -> pin::Pin> + Send + 'mgr>>; + ) -> util::BoxedFuture<'mgr, Result<(), unexpected::Error>>; fn sync_with_config<'mgr>( &'mgr self, domain: domain::Name, config: config::Config, - ) -> pin::Pin> + Send + 'mgr>>; + ) -> util::BoxedFuture<'mgr, Result<(), SyncWithConfigError>>; fn get_acme_http01_challenge_key( &self, @@ -244,8 +244,7 @@ impl Manager for ManagerImpl { fn sync_cert<'mgr>( &'mgr self, domain: domain::Name, - ) -> pin::Pin> + Send + 'mgr>> - { + ) -> util::BoxedFuture<'mgr, Result<(), unexpected::Error>> { Box::pin(async move { if let Some(ref acme_manager) = self.acme_manager { acme_manager.sync_domain(domain.clone()).await?; @@ -259,8 +258,7 @@ impl Manager for ManagerImpl { &'mgr self, domain: domain::Name, config: config::Config, - ) -> pin::Pin> + Send + 'mgr>> - { + ) -> util::BoxedFuture<'mgr, Result<(), SyncWithConfigError>> { Box::pin(async move { let config_hash = config .hash() diff --git a/src/util.rs b/src/util.rs index 9b1b153..1c3afb4 100644 --- a/src/util.rs +++ b/src/util.rs @@ -12,13 +12,13 @@ pub fn open_file(path: &path::Path) -> io::Result> { } } -type StaticFuture = pin::Pin + Send + 'static>>; +pub type BoxedFuture<'a, O> = pin::Pin + Send + 'a>>; pub struct TaskStack where E: error::Error + Send + 'static, { - wait_group: Vec>>, + wait_group: Vec>>, } impl TaskStack