micropelago/garage
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Content-range fix

Browse Source
This commit is contained in:
Alex Auvolat 2020-12-05 16:37:59 +01:00
parent f844d4ee9b
commit 9f46fb699a
1 changed files with 29 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
src/api/s3_get.rs
View File

@ -161,7 +161,7 @@ pub async fn handle_get(
} }
}) })
.buffered(2); .buffered(2);
//let body: Body = Box::new(StreamBody::new(Box::pin(body_stream)));
let body = hyper::body::Body::wrap_stream(body_stream); let body = hyper::body::Body::wrap_stream(body_stream);
Ok(resp_builder.body(body)?) Ok(resp_builder.body(body)?)
} }
@ -183,7 +183,7 @@ pub async fn handle_get_range(
let resp_builder = object_headers(version, version_meta) let resp_builder = object_headers(version, version_meta)
.header( .header(
"Content-Range", "Content-Range",
format!("bytes {}-{}/{}", begin, end, version_meta.size), format!("bytes {}-{}/{}", begin, end - 1, version_meta.size),
) )
.status(StatusCode::PARTIAL_CONTENT); .status(StatusCode::PARTIAL_CONTENT);
@ -206,35 +206,49 @@ pub async fn handle_get_range(
None => return Err(Error::NotFound), None => return Err(Error::NotFound),
}; };
let blocks = version // We will store here the list of blocks that have an intersection with the requested
.blocks() // range, as well as their "true offset", which is their actual offset in the complete
.iter() // file (whereas block.offset designates the offset of the block WITHIN THE PART
.cloned() // block.part_number, which is not the same in the case of a multipart upload)
.filter(|block| block.offset + block.size > begin && block.offset < end) let mut blocks = Vec::with_capacity(std::cmp::min(
.collect::<Vec<_>>(); version.blocks().len(),
4 + ((end - begin) / std::cmp::max(version.blocks()[0].size as u64, 1024)) as usize,
));
let mut true_offset = 0;
for b in version.blocks().iter() {
if true_offset >= end {
break;
}
// Keep only blocks that have an intersection with the requested range
if true_offset < end && true_offset + b.size > begin {
blocks.push((b.clone(), true_offset));
}
true_offset += b.size;
}
let body_stream = futures::stream::iter(blocks) let body_stream = futures::stream::iter(blocks)
.map(move |block| { .map(move |(block, true_offset)| {
let garage = garage.clone(); let garage = garage.clone();
async move { async move {
let data = garage.block_manager.rpc_get_block(&block.hash).await?; let data = garage.block_manager.rpc_get_block(&block.hash).await?;
let start_in_block = if block.offset > begin { let data = Bytes::from(data);
let start_in_block = if true_offset > begin {
0 0
} else { } else {
begin - block.offset begin - true_offset
}; };
let end_in_block = if block.offset + block.size < end { let end_in_block = if true_offset + block.size < end {
block.size block.size
} else { } else {
end - block.offset end - true_offset
}; };
Result::<Bytes, Error>::Ok(Bytes::from( Result::<Bytes, Error>::Ok(Bytes::from(
data[start_in_block as usize..end_in_block as usize].to_vec(), data.slice(start_in_block as usize..end_in_block as usize),
)) ))
} }
}) })
.buffered(2); .buffered(2);
//let body: Body = Box::new(StreamBody::new(Box::pin(body_stream)));
let body = hyper::body::Body::wrap_stream(body_stream); let body = hyper::body::Body::wrap_stream(body_stream);
Ok(resp_builder.body(body)?) Ok(resp_builder.body(body)?)
} }