No need for Close to be part of the Logger interface
This commit is contained in:
parent
5660a9a623
commit
55bc7097f7
@ -25,7 +25,6 @@ const (
|
||||
type Logger interface {
|
||||
Println(string)
|
||||
Printf(string, ...interface{})
|
||||
Close() error
|
||||
}
|
||||
|
||||
// NullLogger is an implementation of Logger which doesn't do anything.
|
||||
@ -35,7 +34,6 @@ var _ Logger = NullLogger{}
|
||||
|
||||
func (NullLogger) Println(string) {}
|
||||
func (NullLogger) Printf(string, ...interface{}) {}
|
||||
func (NullLogger) Close() error { return nil }
|
||||
|
||||
// PlainLogger implements Logger by writing each line directly to the given
|
||||
// io.Writer as-is.
|
||||
@ -53,10 +51,6 @@ func (l PlainLogger) Printf(str string, args ...interface{}) {
|
||||
fmt.Fprintf(l, str, args...)
|
||||
}
|
||||
|
||||
func (l PlainLogger) Close() error {
|
||||
return l.WriteCloser.Close()
|
||||
}
|
||||
|
||||
// PmuxLogger is used by the pmux process itself for logging. It can prefix log
|
||||
// lines with a timestamp, the name of the process being logged, and a custom
|
||||
// separator in front of the log line to help delineate one kind of log from
|
||||
|
@ -23,7 +23,7 @@ type Config struct {
|
||||
type Pmux struct {
|
||||
processes map[string]*Process
|
||||
|
||||
stdoutLogger, stderrLogger, sysLogger Logger
|
||||
stdoutLogger, stderrLogger, sysLogger *PmuxLogger
|
||||
}
|
||||
|
||||
// NewPmux starts a Pmux with the given configuration.
|
||||
|
Loading…
Reference in New Issue
Block a user