db01bce007
* native-tls: fix use of non-fmt panic in tests * fix some misc. clippy lints This branch fixes a number of lints. The most important one was the use of a non-`format_args!` expression in a `panic!` macro, which generates a compiler warning in recent Rust toolchains, which is breaking the CI `cargo check` run on PR #64. While I was here, I also fixed some miscellaneous Clippy lints, mostly in tests. These include: * Use of `clone()` on `SocketAddr`s (which implement `Copy`) * Unnecessary single-path-segment imports (which probably used to be `extern crate`s in earlier Rust?) * `'static` lifetimes in `const` type annotations (`const`s always have the `'static` lifetime) None of these were breaking the build on CI, but I figured I'd address them while I was fixing other lints. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
100 lines
3.3 KiB
Rust
100 lines
3.3 KiB
Rust
#![warn(rust_2018_idioms)]
|
|
|
|
use cfg_if::cfg_if;
|
|
use native_tls::TlsConnector;
|
|
use std::io;
|
|
use std::net::ToSocketAddrs;
|
|
use tokio::io::{AsyncReadExt, AsyncWriteExt};
|
|
use tokio::net::TcpStream;
|
|
|
|
macro_rules! t {
|
|
($e:expr) => {
|
|
match $e {
|
|
Ok(e) => e,
|
|
Err(e) => panic!("{} failed with {:?}", stringify!($e), e),
|
|
}
|
|
};
|
|
}
|
|
|
|
cfg_if! {
|
|
if #[cfg(feature = "force-rustls")] {
|
|
fn assert_bad_hostname_error(err: &io::Error) {
|
|
let err = err.to_string();
|
|
assert!(err.contains("CertNotValidForName"), "bad error: {}", err);
|
|
}
|
|
} else if #[cfg(any(feature = "force-openssl",
|
|
all(not(target_os = "macos"),
|
|
not(target_os = "windows"),
|
|
not(target_os = "ios"))))] {
|
|
fn assert_bad_hostname_error(err: &io::Error) {
|
|
let err = err.get_ref().unwrap();
|
|
let err = err.downcast_ref::<native_tls::Error>().unwrap();
|
|
assert!(format!("{}", err).contains("certificate verify failed"));
|
|
}
|
|
} else if #[cfg(any(target_os = "macos", target_os = "ios"))] {
|
|
fn assert_bad_hostname_error(err: &io::Error) {
|
|
let err = err.get_ref().unwrap();
|
|
let err = err.downcast_ref::<native_tls::Error>().unwrap();
|
|
assert!(format!("{}", err).contains("was not trusted."));
|
|
}
|
|
} else {
|
|
fn assert_bad_hostname_error(err: &io::Error) {
|
|
let err = err.get_ref().unwrap();
|
|
let err = err.downcast_ref::<native_tls::Error>().unwrap();
|
|
assert!(format!("{}", err).contains("CN name"));
|
|
}
|
|
}
|
|
}
|
|
|
|
#[tokio::test]
|
|
async fn fetch_google() {
|
|
drop(env_logger::try_init());
|
|
|
|
// First up, resolve google.com
|
|
let addr = t!("google.com:443".to_socket_addrs()).next().unwrap();
|
|
|
|
let socket = TcpStream::connect(&addr).await.unwrap();
|
|
|
|
// Send off the request by first negotiating an SSL handshake, then writing
|
|
// of our request, then flushing, then finally read off the response.
|
|
let builder = TlsConnector::builder();
|
|
let connector = t!(builder.build());
|
|
let connector = tokio_native_tls::TlsConnector::from(connector);
|
|
let mut socket = t!(connector.connect("google.com", socket).await);
|
|
t!(socket.write_all(b"GET / HTTP/1.0\r\n\r\n").await);
|
|
let mut data = Vec::new();
|
|
t!(socket.read_to_end(&mut data).await);
|
|
|
|
// any response code is fine
|
|
assert!(data.starts_with(b"HTTP/1.0 "));
|
|
|
|
let data = String::from_utf8_lossy(&data);
|
|
let data = data.trim_end();
|
|
assert!(data.ends_with("</html>") || data.ends_with("</HTML>"));
|
|
}
|
|
|
|
fn native2io(e: native_tls::Error) -> io::Error {
|
|
io::Error::new(io::ErrorKind::Other, e)
|
|
}
|
|
|
|
// see comment in bad.rs for ignore reason
|
|
#[cfg_attr(all(target_os = "macos", feature = "force-openssl"), ignore)]
|
|
#[tokio::test]
|
|
async fn wrong_hostname_error() {
|
|
drop(env_logger::try_init());
|
|
|
|
let addr = t!("google.com:443".to_socket_addrs()).next().unwrap();
|
|
|
|
let socket = t!(TcpStream::connect(&addr).await);
|
|
let builder = TlsConnector::builder();
|
|
let connector = t!(builder.build());
|
|
let connector = tokio_native_tls::TlsConnector::from(connector);
|
|
let res = connector
|
|
.connect("rust-lang.org", socket)
|
|
.await
|
|
.map_err(native2io);
|
|
|
|
assert!(res.is_err());
|
|
assert_bad_hostname_error(&res.err().unwrap());
|
|
}
|